Remove note for looping VideoStreamPlayer #7479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As no workarounds are necessary to seamlessly loop videos since godotengine/godot#77856 got merged.
Piralein
added
enhancement
area:manual
mhilbrunner
approved these changes
Jun 9, 2023
|
Thanks for solving that one, and double thanks for taking care of the documentation for it too! 🎉Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove note for looping VideoStreamPlayer. Previously, workarounds were needed to get seamlessly looping video with VideoStreamPlayer nodes. Since godotengine/godot#77856 got merged, no workarounds are necessary anymore, and connecting the
on_finishedsignal to theplay()method produces seamlessly looping video.Also added a warning regarding setting the audio quality too high, as doing so ended up with audio dropouts on my end while debugging the PR. It is probably useful information for the users, especially those targeting low powered devices.